Skip to content

fix(advance-deploy-env): skip branch create/delete (prerequisite for #1274 staging) - #81

Merged
LukasWodka merged 1 commit into
developfrom
fix/advance-skip-branch-creation
Jul 26, 2026
Merged

fix(advance-deploy-env): skip branch create/delete (prerequisite for #1274 staging)#81
LukasWodka merged 1 commit into
developfrom
fix/advance-skip-branch-creation

Conversation

@LukasWodka

@LukasWodka LukasWodka commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

On a branch-creation push the before-hash is all-zeros → the range falls back to 'last 50 commits' → it advances ~50 recent PRs' kanban items. A branch creation merges nothing, so cutting a new staging branch (D8/#1274) would mass-move ~50 items per repo to FR on staging — the same corruption class as the default-branch incident.

Guards the advance job with github.event.created != true && github.event.deleted != true.

Must be on main before any staging branch is cut for #1274. Merge → promote to main → then create staging branches safely.


Note

Low Risk
Single conditional on a CI workflow; reduces incorrect kanban updates with no change to deploy or application runtime behavior.

Overview
Adds a job-level guard on the reusable advance-deploy-env workflow so the advance job does not run when the push event is a branch creation or branch deletion (github.event.created / github.event.deleted).

Without this, a new branch push still has before as the all-zero hash, which triggers the existing “last 50 commits” fallback in the PR-extraction step and can bulk-update many kanban items even though no new work was merged—e.g. when cutting a new staging branch for #1274.

Reviewed by Cursor Bugbot for commit 45941f3. Bugbot is set up for automated code reviews on this repo. Configure here.

On a branch-CREATION push the before-hash is all-zeros, and the range logic
falls back to 'the last 50 commits', extracting and advancing every PR ref in
them. A branch creation merges nothing — the commits are inherited from the
source branch — so this mass-advances ~50 recent PRs' kanban items on every new
branch. That makes cutting a new 'staging' branch (D8/#1274) corrupt the board,
the same class as the default-branch-change incident.

Guard the advance job with 'github.event.created != true && github.event.deleted
!= true'. A create/delete is not a deploy event.

Prerequisite for #1274 (create staging in every repo) — must be on main before
any staging branch is cut.
@LukasWodka LukasWodka self-assigned this Jul 26, 2026
@LukasWodka

Copy link
Copy Markdown
Contributor Author

👋 Heads-up — Code review queue is at 40 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@LukasWodka

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 45941f3. Configure here.

@LukasWodka
LukasWodka merged commit 67b204c into develop Jul 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant