fix(macros): tolerate unreadable dotenv with query source - #4371
Open
Boulea7 wants to merge 1 commit into
Open
Conversation
Ignore dotenv I/O errors only when a query source was established before reading that file. Continue to report parse errors and mid-file I/O failures when the current file established the source. Fixes transact-rs#4348 Developed with AI assistance. Signed-off-by: zhanglangning <zln1905391059@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Fixes #4348.
The query macro environment loader now ignores a dotenv I/O error only when DATABASE_URL or SQLX_OFFLINE had already established a usable query source before that file was opened. An I/O error partway through the file that establishes the source is still reported, so later settings such as SQLX_OFFLINE_DIR are not silently skipped. Dotenv parse errors are still reported, and process environment values retain precedence.
Is this a breaking change?
No. This only allows compilation to continue past an unreadable later or parent dotenv file when a query source is already available.
Testing
AI assistance
Developed with AI assistance.