fix(send): retain diagnostics and fail exit status for failed execution - #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
A failed send receipt no longer reports success to callers. Fixes #189.
Work authority
Plan
Recognize failed terminal send receipts at the common command boundary; keep receipt diagnostics and return nonzero; test successful and failed cases.
Changes and commits
cc8bd0d adds terminal status handling and two regression tests.
Verification
Two focused command-boundary tests passed. Managed CLI generation 8 activated; Actions pending. 1253402 groups the test by communication ownership.
Risk and rollback
No schema, API contract, or credential changes. Only failed sends change exit status. Revert CLI source through managed development if required.
Completion summary
Bounded implementation complete; Actions and activation remain gates. This does not claim to repair the underlying sandbox failure.
Submission checklist