fix(auth): retain session across pre-refresh discovery outages - #194
Merged
Conversation
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Do not erase a valid encrypted session when API/issuer discovery fails before renewal submits a refresh token.
Work authority
Plan
Keep discovery and renewal within the serialized session transaction. Begin failure invalidation only immediately before refresh invocation.
Changes and commits
251a50e introduces a transaction invalidation predicate. Unavailable discovery preserves the session and team. Ambiguous refresh continues to clear the selected session. No alternate credential storage or authentication bypass.
Verification
Three synthetic resource/issuer/refresh outage tests pass; all four existing custody tests passed in the preceding focused run. Strict TypeScript and file architecture pass. CLI distribution rebuilt without touching unrelated generated docs/schema edits. Actions required on exact head.
Risk and rollback
Session invalidation behavior is deliberately unchanged once refresh begins, including uncertain token rotation. Revert this commit to restore prior behavior. Already-erased credentials are not recovered; browser sign-in remains required.
Completion summary
The identified pre-refresh outage defect is fixed. This does not assert successful live source-enabled agent execution.
Submission checklist