Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .server-changes/quiet-expected-error-logs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
area: webapp
type: improvement
---

Log expected auth-code and checkpoint-restore conditions at `warn` instead of `error`.
11 changes: 7 additions & 4 deletions apps/webapp/app/routes/api.v1.token.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,13 @@ export async function action({ request }: ActionFunctionArgs) {
return json(responseJson);
} catch (error) {
if (error instanceof Error) {
logger.error("Error getting PersonalAccessToken from AuthorizationCode", {
url: request.url,
error: error.message,
});
const expected = error.message === "Invalid authorization code, or code expired";
const fields = { url: request.url, error: error.message };
if (expected) {
logger.warn("Error getting PersonalAccessToken from AuthorizationCode", fields);
} else {
logger.error("Error getting PersonalAccessToken from AuthorizationCode", fields);
}

return json({ error: error.message }, { status: 400 });
}
Expand Down
2 changes: 1 addition & 1 deletion apps/webapp/app/v3/services/restoreCheckpoint.server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class RestoreCheckpointService extends BaseService {
});

if (restoreEvent) {
logger.error("Restore event already exists", {
logger.warn("Restore event already exists", {
runId: checkpoint.runId,
attemptId: checkpoint.attemptId,
checkpointId: checkpoint.id,
Expand Down