Skip to content

ci: restrict ci workflow permissions to read-only - #81

Merged
hashhar merged 1 commit into
trinodb:mainfrom
arpitjain099:chore/workflow-permissions
Oct 2, 2026
Merged

hashhar merged 1 commit into
trinodb:mainfrom
arpitjain099:chore/workflow-permissions

Conversation

@arpitjain099

Copy link
Copy Markdown
Member

Each of these workflows runs without a top-level permissions: block, so its GITHUB_TOKEN inherits the repository (or org) default, which is frequently read/write for all scopes.

Setting contents: read explicitly on .github/workflows/ci.yml keeps the workflow token scoped to what the job actually uses. If a third-party action or transitive dependency in the run were ever compromised, a read-only token limits the damage (no pushes, no releases, no token-backed writes). The change is mechanical and does not alter any step.

Set an explicit least-privilege permissions block so the workflow GITHUB_TOKEN is scoped to contents: read instead of inheriting the repository default.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@cla-bot

cla-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@arpitjain099

Copy link
Copy Markdown
Member Author

@hashhar @nineinchnick could one of you re-run the CLA check here when you get a chance?

I signed the Trino Foundation individual CLA some months ago, and it is on file: the same verification/cla-signed check passes on my PR in trino-python-client, trinodb/trino-python-client#624. This PR predates the signature, so the bot here is still showing the result from before and has not rechecked since.

No rush on reviewing the change itself, I just did not want the stale check to be the reason it sits.

@nineinchnick

Copy link
Copy Markdown
Member

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label Oct 2, 2026
@cla-bot

cla-bot Bot commented Oct 2, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@hashhar
hashhar merged commit ffad6b5 into trinodb:main Oct 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants