ci: restrict ci workflow permissions to read-only - #81
Conversation
Set an explicit least-privilege permissions block so the workflow GITHUB_TOKEN is scoped to contents: read instead of inheriting the repository default. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@hashhar @nineinchnick could one of you re-run the CLA check here when you get a chance? I signed the Trino Foundation individual CLA some months ago, and it is on file: the same No rush on reviewing the change itself, I just did not want the stale check to be the reason it sits. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Each of these workflows runs without a top-level
permissions:block, so itsGITHUB_TOKENinherits the repository (or org) default, which is frequently read/write for all scopes.Setting
contents: readexplicitly on.github/workflows/ci.ymlkeeps the workflow token scoped to what the job actually uses. If a third-party action or transitive dependency in the run were ever compromised, a read-only token limits the damage (no pushes, no releases, no token-backed writes). The change is mechanical and does not alter any step.