Do not retry spooling-related GET requests with status code 200 and empty body - #640
Closed
azawlocki-sbdt wants to merge 1 commit into
Conversation
azawlocki-sbdt
force-pushed
the
azawlocki/fix-performance-regression-for-spooling-requests
branch
from
September 22, 2026 12:49
cb823d8 to
4445404
Compare
The client currently treats all GET requests to which Trino responds with status code 200 and empty body as failed and retries them. But the empty body is a normal response for segment acknowledgements requests, they should not be retried if the status is 200. This change fixes that by turning off body emptiness checking (effectively reverting PR trinodb#603) for spooling-releted requests. Additional minor change is to access `content` rather than `text` when checking for emptiness, to avoid decoding binary responses to text just to see if they are not empty.
azawlocki-sbdt
force-pushed
the
azawlocki/fix-performance-regression-for-spooling-requests
branch
from
September 22, 2026 12:50
4445404 to
0fcca9e
Compare
Contributor
|
Isn't this a duplicate fix if this #637 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since #603, the client treats all GET requests to which the server responds with status code 200 and empty body as failed and retries them. But the empty body is a normal response for segment acknowledgements requests, they should not be retried if the status is 200.
This PR fixes that by turning off body emptiness checking (effectively reverting PR #603) for spooling-releted requests. For simplicity, emptiness checking is turned off for spooling data requests, as well as spooling
acknowledgement requests.
Additional minor change is to access
contentrather thantextwhen checking for emptiness, to avoid decoding binary responses to text just to see if they are not empty.Non-technical explanation
A fix for the bug that resulted in retrying successful segment acknowledgement requests, leading to performance degradation when downloading a large number of segments.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: