Skip to content

feat: Add config-manager pull iga-workflows command#102

Closed
dallinjsevy wants to merge 1 commit into
mainfrom
feature/config-manager-pull-iga-workflows
Closed

feat: Add config-manager pull iga-workflows command#102
dallinjsevy wants to merge 1 commit into
mainfrom
feature/config-manager-pull-iga-workflows

Conversation

@dallinjsevy

Copy link
Copy Markdown

No description provided.

Comment thread src/cli/config-manager/config-manager-pull/config-manager-pull-iga-workflows.ts Outdated
Comment thread src/cli/config-manager/config-manager-pull/config-manager-pull-iga-workflows.ts Outdated
Comment thread src/cli/config-manager/config-manager-pull/config-manager-pull-iga-workflows.ts Outdated
Comment thread src/cli/config-manager/config-manager-pull/config-manager-pull-iga-workflows.ts Outdated
Comment thread src/configManagerOps/FrConfigIgaWorkflowsOps.ts Outdated
Comment thread src/configManagerOps/FrConfigIgaWorkflowsOps.ts Outdated
Comment thread src/configManagerOps/FrConfigIgaWorkflowsOps.ts Outdated
Comment thread test/client_cli/en/config-manager-export-iga-workflows.test.js Outdated
Comment thread test/e2e/config-manager-export-iga-workflows.e2e.test.js
Comment thread src/cli/config-manager/config-manager-pull/config-manager-pull-iga-workflows.ts Outdated
Comment thread src/configManagerOps/FrConfigIgaWorkflowsOps.ts Outdated
@phalestrivir

Copy link
Copy Markdown

Make sure to rebase with main once my PR here gets merged in: rockcarver#631

@phalestrivir phalestrivir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor changes needed.

And note that once the PR I made for normal Frodo workflow commands is merged in you will want to rebase this PR with the main branch so that it fixes all the onlyCustom errors. You may want to wait to make the changes until then

Comment thread src/cli/config-manager/config-manager-pull/config-manager-pull-iga-workflows.ts Outdated
Comment thread src/cli/config-manager/config-manager-pull/config-manager-pull-iga-workflows.ts Outdated
Comment thread src/configManagerOps/FrConfigIgaWorkflowsOps.ts Outdated
Comment thread test/e2e/config-manager-export-iga-workflows.e2e.test.js Outdated
@dallinjsevy
dallinjsevy force-pushed the feature/config-manager-pull-iga-workflows branch from d3b20b1 to cb3a0cf Compare July 21, 2026 16:54
Comment thread src/cli/config-manager/config-manager-pull/config-manager-pull-iga-workflows.ts Outdated
Comment thread test/e2e/config-manager-export-iga-workflows.e2e.test.js
Comment thread src/ops/ConfigOps.ts
Comment thread src/utils/Config.ts
@dallinjsevy
dallinjsevy force-pushed the feature/config-manager-pull-iga-workflows branch 3 times, most recently from 6facd74 to fd8512e Compare July 22, 2026 14:57

@phalestrivir phalestrivir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a bug. Once we have that fixed we should be good to go

Comment thread src/configManagerOps/FrConfigIgaWorkflowsOps.ts Outdated
Comment thread src/configManagerOps/FrConfigIgaWorkflowsOps.ts Outdated
@dallinjsevy
dallinjsevy force-pushed the feature/config-manager-pull-iga-workflows branch from 103e941 to 3ea65d0 Compare July 22, 2026 15:32

@phalestrivir phalestrivir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the test files use "export" instead of "pull" in the names, so that's the only thing that needs to be changed. Once you fix that squash your commits and create the PR against Rockcarver.

Comment thread test/client_cli/en/config-manager-pull-iga-workflows.test.js
Comment thread test/e2e/config-manager-pull-iga-workflows.e2e.test.js
@dallinjsevy
dallinjsevy force-pushed the feature/config-manager-pull-iga-workflows branch from 3ea65d0 to bfb2276 Compare July 22, 2026 22:05
@dallinjsevy
dallinjsevy force-pushed the feature/config-manager-pull-iga-workflows branch from bfb2276 to fc013a0 Compare July 22, 2026 22:05
@phalestrivir

Copy link
Copy Markdown

PR created against Rockcarver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants