feat: add -c, --clean flag to config-manager journeys#117
Conversation
brycentrivir
changed the title
There was a problem hiding this comment.
You forgot to run npm run lint:fix
Additionally, I tried to run the config-manager-export-journeys e2e test and it's failing at the moment, I think because of the journey updates Volker made in the library to fix node exports, so you will need to fix that test and re-update the snapshots (I would rebase with the main branch as well to get the latest updates from main since you will likely need those to rebuild the executable).
8b0fc97 to
914e447
Compare
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
Resolve my new comment, there is a missing function comment for configManagerExportJourneys (make sure to include the types for the parameters in the comments). Additionally, you still need to run npm run lint:fix. After that, you can squash these commits and create the PR against Rockcarver
f31ea5a to
8636b2a
Compare
feat: add -c, --clean flag config-manager journeys
8636b2a to
840bed5
Compare
2 participants
The
-c, --cleanflag was not implemented yet in Frodo's version of config-manager. Added that in using same logic fromfr-config-pull journeys