feat: Add coonfig-manager push services command#86
Conversation
816bcf7 to
ba61d3c
Compare
d433546 to
1953746
Compare
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
I rebased, and also added some test configuration. One thing I noticed is that I don't think you are importing the next descendents correctly, so I added a few descendent configurations to the social provider service in the root realm that you can use for testing the descendents (the id-repositories service also has one too)
1e011e2 to
36566cf
Compare
36566cf to
f1341f1
Compare
| let realms: string[] = []; | ||
|
|
||
| if (realm === '__default__realm__' || !realm) { | ||
| const realmsDir = getFilePath('realms/'); |
There was a problem hiding this comment.
We have a problem here. When exporting with Forgeops, the root realm doesn't have a directory, it's just called services, so on import it will think services is a realm. We should have it be saved to a directory called root, so update the pull command to handle that, and then on import if you see a directory named root import to the / realm since root is not technically the name of it.
There was a problem hiding this comment.
For your tests for services, could you use the services from: https://git.trivir.com/projects/TRIVIR/repos/frodo-forgeops-test-config/browse
I added several several services in the root realm, and there are some in the other realms as well, which would be great for testing the root realm as well as the others. You will need to delete the old test files in this repo and replace them with the export from forgeops after you import the services from https://git.trivir.com/projects/TRIVIR/repos/frodo-forgeops-test-config/browse
b620c53 to
ec1d311
Compare
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
The main change you still need to make is to add test configuration for root realm since you are only testing alpha/bravo at the moment. As I mentioned in my last review, you should use the test data I have created in https://git.trivir.com/projects/TRIVIR/repos/frodo-forgeops-test-config/browse. Import it into your forgeops and then re-export it using frodo config-manager and use those for your test configuration under test/e2e/exports/fr-config-manager/forgeops/realms/root/services, test/e2e/exports/fr-config-manager/forgeops/realms/alpha/services, and test/e2e/exports/fr-config-manager/forgeops/realms/bravo/services
2 participants
No description provided.