feat: Add config-manager push restart command#97
Conversation
5c40799 to
092fe7a
Compare
4af46ce to
b2cca19
Compare
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
Make sure to run npm run lint:fix when you are finished with these last changes, I noticed a few formatting issues that would've been fixed with it.
| if (restartStatus === 'restarting') { | ||
| printMessage('Environment already restarting.', 'error'); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Sorry if this wasn't clear in my last review, but this if statement should come after the if statement for status, but before the if statement for check like it does in config manager, that way you can still read the status even if the tenant is restarting.
55e89f8 to
1f45527
Compare
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
I noticed the test for -w would take about two minutes to run, and not only that, but sometimes the snapshot would differ because the amount of time it takes would be different, so I modified the test to timeout if it goes longer than 5 seconds and save what it received into snapshots, and that fixed the issue.
With that the PR is done, so I would squash the commits (after you pull down the test fix
commit I made) and then rebase with main if needed before submitting the PR against Rockcarver
66bb3f7 to
ad6edfd
Compare
cdae07e to
2d37686
Compare
2 participants
No description provided.