Unify page chrome, paginate MCP selectors, and sandbox New Chat - #598
Unify page chrome, paginate MCP selectors, and sandbox New Chat#598govindavashishtha wants to merge 3 commits into
Conversation
Share PageHeader across chat/list surfaces, infinite-scroll MCP catalogs, and enable sandbox on New Chat when capabilities allow. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 9c57024 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
- Introduced a new AgentConfigInstructionsContext to manage agent configuration instructions, allowing for draft saving and flushing. - Updated SaveAgentButton to utilize the new context for handling instructions. - Enhanced AgentConfigPanel and related components to improve layout and visibility in full-width builder modes. - Made mobile configuration overlays closable and preserved widget states across chat runtime changes. - Adjusted TypeScript configurations to include custom conditions for development. These changes collectively enhance the user experience and maintain consistency across the TrueForge UI.
Keep off-page MCP mounts across paginated catalogs, restore Settings back control, and let PageHeader grow when actions wrap. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Addressed Cursor Bugbot review comments:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9c57024. Configure here.
| ); | ||
| observer.observe(sentinelEl); | ||
| return () => observer.disconnect(); | ||
| }, [enabled, hasMore, loading, listEl, sentinelEl, rootMargin]); |
There was a problem hiding this comment.
Failed MCP pages retry forever
Medium Severity
Re-creating the observer whenever loading settles immediately recalls onLoadMore if the sentinel is still visible. A failed loadMoreConnectors leaves connectorsHasMore true, so a short or filtered list retries the same listMcp page in a tight loop with no backoff.
Reviewed by Cursor Bugbot for commit 9c57024. Configure here.
2 participants
#598
Summary
PageHeaderacross chat and list chrome so title size/height stay consistent; drop decorative title icons and the Settings back buttonlistMcppages viaDraftCatalogProvider@truefoundry/assistant-ui-runtimeto 0.1.27Test plan
listMcppagespnpm --filter @truefoundry/trueforge-ui testfor touched atom/provider/adapter testsMade with Cursor