fixed regex typo that was causing conf uuid's to be surfaced as non-live atlassian secrets.#5029
fixed regex typo that was causing conf uuid's to be surfaced as non-live atlassian secrets.#5029jordanTunstill wants to merge 2 commits into
Conversation
Corpora Test ResultsScans a corpus of real-world public code against only the detectors changed in this PR, then compares unique match counts between the PR build and the main baseline to catch regex regressions. Verification is disabled — each detector's regex is measured independently. 1 regressed · 0 new · 0 clean | Scoped to:
|
MuneebUllahKhan222
left a comment
There was a problem hiding this comment.
This change is acceptable, but note that the v1 detector targets Atlassian classic tokens, which are no longer issuable and cannot be used for verification anymore. Additionally, our secret manager does not contain any classic tokens for validation.
Given this, if we are comfortable taking the assumption that classic tokens do not include a -, then removing support for - is reasonable.
The LLM analysis also aligns with this, indicating that classic tokens do not contain hyphens.
Fix(atlassian/v1): removes stray dash from keyPat character class
The character class
[a-zA-Z-0-9]accidentally admitted-as aliteral, allowing the detector to carve a 24-char slice out of UUID-
shaped strings (e.g. Confluence
ac:macro-id="451a36ca-3009-404c-a6b2- 63cb71b229ce") when the keyword "atlassian" appeared within 40 chars.Real classic Atlassian API tokens are 24 alphanumeric characters with
no dashes, this tightens the class to
[a-zA-Z0-9]and adds a regressiontest.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Cursor Bugbot is generating a summary for commit 4246f15. Configure here.