Repository navigation
Conversation
|
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The Chroma setup is complete, API-compatible, and consistently integrated into the existing test infrastructure.
Review effort: Balanced
Findings: None
What changed in this PR
Adds Chroma 1.5.9 to the shared vector-store integration test suite using ChromaDotNet.VectorData.
Changes:
- Adds Chroma as a supported database and configures its container.
- Adds the Chroma vector-store dependency.
- Runs all seven vector-store integration tests against Chroma.
| File | Description |
|---|---|
src/IntegrationTests/SupportedDatabase.cs |
Adds the Chroma database option. |
src/IntegrationTests/LangChain.Databases.IntegrationTests.csproj |
References the Chroma provider. |
src/IntegrationTests/DatabaseTests.cs |
Enables Chroma across vector-store tests. |
src/IntegrationTests/DatabaseTests.Configure.cs |
Starts and configures Chroma 1.5.9. |
src/Directory.Packages.props |
Pins ChromaDotNet.VectorData 0.4.1. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Laurianti
force-pushed
the
add-chroma
branch
2 times, most recently
from
October 7, 2026 10:25
21b91ae to
a5adea2
Compare
The vector store tests run on Chroma 1.5.9 too, through ChromaDotNet.VectorData, a Microsoft.Extensions.VectorData provider for Chroma.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #179
Adds Chroma to the databases of the integration tests:
SupportedDatabase.Chroma, achromadb/chroma:1.5.9container started like the OpenSearch one, and[TestCase(SupportedDatabase.Chroma)]on the 7 tests ofDatabaseTests, which all pass.The Chroma row of the README now names ChromaDotNet.VectorData:
Microsoft.SemanticKernel.Connectors.Chromastill uses the v1 API (#179).Chroma runs on ChromaDotNet.VectorData today. The same provider is proposed to the AI Community Toolkit as
CommunityToolkit.VectorData.Chroma(CommunityToolkit/AI#58): when that package ships, these tests move onto it. I maintain ChromaDotNet.To run the Chroma tests, with Docker running: