Repository navigation
Keep the selected speech engine after a call ends with low-latency audio on - #201
Merged
Merged
Conversation
…dio on trypsynth#190 kept calls on the engine's own playback, because engines said nothing about the first speech after the audio mode changed and the 3 s hang check moved to another engine. The mode changes back when the call ends, and the next speech went through low-latency audio again, so Backtalk moved to Google's engine then instead. - Speech plays the usual way for 10 s after the audio mode changes. A change seen only when speech starts counts from then. - The hang check waits up to 20 s, as for an engine that is speaking, when the audio mode changed after the speech was sent. This also covers low-latency speech that started just before a call. Limitation: speech for 10 s after a call starts or ends has the usual latency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#190 plays speech the usual way during calls, because engines said nothing about the first speech after the audio mode changed, and the 3 s hang check moved to another engine. Ending a call changes the audio mode back. A user reports that since #190, Backtalk moves to Google's engine after a call ends instead of when it starts. The next speech goes through low-latency audio again and hits the same hang check. This cause is inferred from the code; there is no logcat from the report.
Limitations:
Not tested on a call. Unit tests pass.