Repository navigation
Conversation
Skip tray icon and popup menu creation on macOS, where the Dock already reopens the main window. Keep tray setup and cleanup on other platforms. Gate tray-only imports, account for the unused tray command on macOS, and document reopening Fedra from the Dock. Validation: cargo check --locked on aarch64-apple-darwin, formatting checks for changed Rust files, and git diff --check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Fedra's macOS menu bar status icon and its Show/Hide menu. macOS skips tray creation and cleanup; the existing Dock reopen handler brings the main window back. Other platforms retain their tray behavior.
Gate tray-only imports, account for the tray-only command on macOS, and document reopening Fedra from the Dock.
Validation:
cargo check --lockedon Apple Silicon macOS, formatting checks for the changed Rust files,git diff --check, and all applicable pre-commit hooks passed.