Skip to content

[INF-7570] startupProbe support for all deployments - #366

Merged
lukefoster11 merged 2 commits into
mainfrom
more-startup-probes
Aug 25, 2026
Merged

[INF-7570] startupProbe support for all deployments#366
lukefoster11 merged 2 commits into
mainfrom
more-startup-probes

Conversation

@lukefoster11

@lukefoster11 lukefoster11 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Add startup probe support in the chart for all deployments, addressing issues with both workflows-backend and agent-sandbox-controller slow startups

@lukefoster11
lukefoster11 marked this pull request as ready for review August 24, 2026 23:00
@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains.

Important Files Changed

Filename Overview
charts/retool/templates/_helpers.tpl Adds a shared conditional renderer supporting HTTP and TCP startup probes.
charts/retool/values.yaml Enables startup probes by default and defines workload-specific endpoints and startup windows.
values.yaml Mirrors the chart’s new public startup-probe defaults.
charts/retool/templates/_workers.tpl Applies worker-specific startup probes through the shared worker template and health port.
charts/retool/templates/deployment_workflows.yaml Adds the workflow-backend startup probe using its component-specific configuration.
charts/retool/templates/deployment_agent_sandbox.yaml Adds startup protection to both the sandbox controller and proxy.
charts/retool/templates/deployment_backend.yaml Replaces the backend’s inline startup-probe rendering with the shared helper.

Reviews (2): Last reviewed commit: "all deployments" | Re-trigger Greptile

@lukefoster11 lukefoster11 changed the title [INF-7570] startupProbe support for workflows-backend + agent-sandbox-controller [INF-7570] startupProbe support for all deployments Aug 25, 2026
@lukefoster11

Copy link
Copy Markdown
Contributor Author

@greptile review me again pls

@lukefoster11
lukefoster11 merged commit 6ce41ec into main Aug 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants