[INF-7570] startupProbe support for all deployments - #366
Merged
Conversation
lukefoster11
marked this pull request as ready for review
August 24, 2026 23:00
Contributor
|
| Filename | Overview |
|---|---|
| charts/retool/templates/_helpers.tpl | Adds a shared conditional renderer supporting HTTP and TCP startup probes. |
| charts/retool/values.yaml | Enables startup probes by default and defines workload-specific endpoints and startup windows. |
| values.yaml | Mirrors the chart’s new public startup-probe defaults. |
| charts/retool/templates/_workers.tpl | Applies worker-specific startup probes through the shared worker template and health port. |
| charts/retool/templates/deployment_workflows.yaml | Adds the workflow-backend startup probe using its component-specific configuration. |
| charts/retool/templates/deployment_agent_sandbox.yaml | Adds startup protection to both the sandbox controller and proxy. |
| charts/retool/templates/deployment_backend.yaml | Replaces the backend’s inline startup-probe rendering with the shared helper. |
Reviews (2): Last reviewed commit: "all deployments" | Re-trigger Greptile
ryanartecona
approved these changes
Aug 24, 2026
Contributor
Author
|
@greptile review me again pls |
ryanartecona
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add startup probe support in the chart for all deployments, addressing issues with both workflows-backend and agent-sandbox-controller slow startups