Keep global transit tails out of fanout phases - #3986
Closed
ShiboSoftwareDev wants to merge 1 commit into
Closed
ShiboSoftwareDev wants to merge 1 commit into
ShiboSoftwareDev wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The T113-S3 HDMI breakout produces a group-owned pad-to-boundary connection and a later global boundary-to-boundary connection with the same
source_trace_id. The phase filter matched both through the source trace, so the fanout solver received the global transit tail even though that segment belongs to the later global phase.Change
When an active routing group has an explicit connection for a source trace, its fanout phase now excludes the ungrouped sibling for that trace. If no group-owned split exists, the existing source-trace matching behavior remains unchanged.
The regression uses the exact 27-connection HDMI fanout input captured from the 96-component T113-S3 Linux board. Its SVG shows the blue global tail present before filtering and deferred after the fix.
Validation
bun test tests/repros/repro-t113-fanout-phase-transit.test.ts tests/utils/autorouting/phased-autorouting-bounds.test.ts tests/utils/autorouting/differential-pair-phase-filter.test.ts tests/repros/repro-shared-capacitor-breakout-handoff.test.tsxgit diff --check origin/main...HEAD