Skip to content

Update alert.mdx - #43087

Merged
julien-deramond merged 3 commits into
twbs:mainfrom
nickalbrecht:patch-1
Oct 15, 2026
Merged

julien-deramond merged 3 commits into
twbs:mainfrom
nickalbrecht:patch-1

Conversation

@nickalbrecht

Copy link
Copy Markdown
Contributor

Correction for a element

Description

Fix for what I believe is a typo, in the documentation for an example usage of the Alert component

Motivation & Context

Bug fix

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Correction for a <vstack> element
@julien-deramond julien-deramond added v6 v6, the main branch docs Documentation site and its content labels Oct 15, 2026
@julien-deramond
julien-deramond self-requested a review October 15, 2026 19:40
@github-project-automation github-project-automation Bot moved this to Inbox in v6.0.0 Oct 15, 2026
…with `.vstack`

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@julien-deramond julien-deramond added the html Component markup: elements, attributes, structure label Oct 15, 2026
…at `.vstack` margins no longer collapse

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@julien-deramond julien-deramond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickalbrecht! Indeed <vstack> isn’t an element Bootstrap styles, so <div class="vstack"> is the right fix. The cheatsheet’s alert example had the same typo, so I pushed a commit to fix it too. Since .vstack is a flex column, the margins around the <hr> no longer merge with the paragraph’s, which added extra space above the line. A second commit adds .mt-0 on the <hr> in both examples, so they look exactly as before. LGTM

@julien-deramond julien-deramond added the examples The examples in the docs label Oct 15, 2026
@julien-deramond
julien-deramond merged commit cc127d8 into twbs:main Oct 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation site and its content examples The examples in the docs html Component markup: elements, attributes, structure v6 v6, the main branch

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants