Repository navigation
New breadcrumb variable for divider spacing - #43091
Merged
Merged
Conversation
julien-deramond
added
v6
mdo
requested changes
Oct 20, 2026
Contributor
Author
|
@mdo Great catch, sorry for that, I'll try to match the existing CSS var names in the future. I've applied the changes. |
Contributor
Author
|
Sorry for the inclusion of the alert component changes, that was supposed to be for a new, different PR (I'll open a new one soon), so please ignore those. |
mdo
approved these changes
Oct 21, 2026
This change adds a new breadcrum divider variable for cases when we need the breadcrumb to be flush with the content, but also control the spacing for the breadcrumb divider. The old way was calculating the margin inline based on the divider item's padding-x and dividing it by a value (4), but if padding-x was set to 0, there was no way to customize this without applying an utility class over the divider element itself.
Co-authored-by: Mark Otto <markdotto@gmail.com>
This was supposed to be for a different PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new breadcrum divider variable (
--breadcrumb-divider-margin-inline) for cases when we need the breadcrumb to be flush with the content, but also control the spacing for the breadcrumb divider.Motivation & Context
The old way was calculating the margin inline based on the divider item's
padding-xand dividing it by a value (4), but ifpadding-xwas set to 0 for the breadcrumb-item, there was no way to customize the spacing for the breadcrumb-divider without applying an utility class over the divider element itself.Example
Personally, I'm in favor of utility classes to override stuff, but generally to add new functionality, not to remove (in this case to remove the margin).
I thought this might be useful, but if I missed something (e.g: we can already achieve the same result with the already existing options), or if you believe this should be handled using utility classes instead, feel free to decline de PR.