Repository navigation
Conversation
`_toggleMenu` added `.show` after Menu auto-close. The pane transition made that update land last, so the nav-overflow More menu opened again. Keep `.active` on the toggle that holds the current tab. Menu owns the open state. A tab that leaves the menu still clears the toggle. Fixes twbs#43092 Co-authored-by: ump45nose <ump45nose@users.noreply.github.com>
julien-deramond
added
v6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.showor setsaria-expandedwhen it activates a tab inside a menu..activewhile it holds the current tab..activefrom the toggle and closes the menu.Motivation & Context
A click on a tab inside a nav-overflow More menu switches the pane. Menu auto-close then hides the menu. The tab pane has a transition, so
Tab#_toggleMenuruns after that close and puts.showback on.nav-overflow-menu. It also setsaria-expanded="true"on the toggle._toggleMenuhas toggled.showsince the tab ARIA rewrite. Before that rewrite, Tab only added.activeto the toggle. The pane transition makes the.showupdate land afterMenu.clearMenus.This change was prepared with AI assistance (Cursor agent) and reviewed before submission.
The active mark can still be lost when overflow is recalculated on resize. That is a separate bug. This change does not fix it.
Type of changes
Checklist
npm run lint)Related issues
Fixes #43092
Tests
npm run lint: exit 0 (0 errors; remaining warnings are pre-existing)npm run js-typecheck: exit 0npx vitest run ... tab.spec.js nav-overflow.spec.js menu.spec.js: 3 files, 262 tests passed