Skip to content

Fix combobox search items that show above the sticky search - #43096

Open
ump45nose wants to merge 2 commits into
twbs:mainfrom
ump45nose:cursor/fix-43036-combobox-search-sticky-10eb
Open

ump45nose wants to merge 2 commits into
twbs:mainfrom
ump45nose:cursor/fix-43036-combobox-search-sticky-10eb

Conversation

@ump45nose

Copy link
Copy Markdown

Description

The sticky combobox search used top: 0. The menu has block padding. The search stuck below that padding. Scrolled options showed in that strip.

The search now uses top: calc(-1 * var(--menu-padding-y, .25rem)). It covers the menu block padding when the menu scrolls. The unscrolled layout stays the same.

npm run css-lint passed. npm run css passed. npm run lint passed. No combobox Sass test exists under scss/tests. A headless Chrome page confirmed the bug on main, then confirmed the fix. The hit target in the padding strip changed from a menu item to .combobox-search. The unscrolled menu pixels did not change.

This change was prepared with AI assistance (Cursor agent) and reviewed before submission.

Motivation & Context

A combobox menu with a search field lets option text show above the search while the user scrolls. The sticky search did not cover the menu block padding.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

Fixes #43036

The search stuck below the menu block padding. Scrolled items showed in that strip. Offset the sticky search by that padding.

Co-authored-by: ump45nose <ump45nose@users.noreply.github.com>
@ump45nose
ump45nose requested a review from a team as a code owner October 16, 2026 05:50
@julien-deramond julien-deramond added v6 v6, the main branch bug Something does not work as documented css Sass sources or compiled CSS labels Oct 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something does not work as documented css Sass sources or compiled CSS v6 v6, the main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v6: Combobox search menu items are visible behind the search box

3 participants