Repository navigation
Conversation
The search stuck below the menu block padding. Scrolled items showed in that strip. Offset the sticky search by that padding. Co-authored-by: ump45nose <ump45nose@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The sticky combobox search used
top: 0. The menu has block padding. The search stuck below that padding. Scrolled options showed in that strip.The search now uses
top: calc(-1 * var(--menu-padding-y, .25rem)). It covers the menu block padding when the menu scrolls. The unscrolled layout stays the same.npm run css-lintpassed.npm run csspassed.npm run lintpassed. No combobox Sass test exists underscss/tests. A headless Chrome page confirmed the bug onmain, then confirmed the fix. The hit target in the padding strip changed from a menu item to.combobox-search. The unscrolled menu pixels did not change.This change was prepared with AI assistance (Cursor agent) and reviewed before submission.
Motivation & Context
A combobox menu with a search field lets option text show above the search while the user scrolls. The sticky search did not cover the menu block padding.
Type of changes
Checklist
npm run lint)Related issues
Fixes #43036