Repository navigation
Docs: add <main> landmark to homepage masthead - #43102
Closed
TanmayNileshShinde wants to merge 1 commit into
Closed
TanmayNileshShinde wants to merge 1 commit into
TanmayNileshShinde wants to merge 1 commit into
Conversation
Member
|
Thanks for your PR @TanmayNileshShinde but I used a slightly different approach via #43105 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the homepage masthead wrapper in site/src/components/home/MastHead.astro from a generic
Motivation & Context
Fixes #43045.
As noted in #43045 and flagged by accessibility checks (Lighthouse / axe-core landmark-one-main), the v6 homepage lacked a primary
landmark.Using
provides the required landmark for assistive technologies and correctly grounds the skip link (href="#content") without altering visual styles.Type of changes
Checklist
Related issues
Closes #43045