Repository navigation
Combobox: add showChips option to render multiple selections as chips - #43117
Open
chsrajavarma8 wants to merge 1 commit into
Open
chsrajavarma8 wants to merge 1 commit into
chsrajavarma8 wants to merge 1 commit into
Conversation
With multiple and showChips enabled, each selected item is shown as a chip in the toggle instead of "X selected". Clicking a chip's dismiss icon deselects that item without toggling the menu, and Backspace or Delete on the focused toggle deselects the last one. The option is named showChips because data-bs-chips already initializes the Chips component. Closes twbs#43035
julien-deramond
added
v6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With multiple and showChips enabled, each selected item is shown as a chip in the toggle instead of "X selected". Clicking a chip's dismiss icon deselects that item without toggling the menu, and Backspace or Delete on the focused toggle deselects the last one.
The option is named showChips because data-bs-chips already initializes the Chips component.
Closes #43035
Description
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues