Repository navigation
Keep drawer tokens inside @layer components - #43136
Open
samyferhat wants to merge 1 commit into
Open
samyferhat wants to merge 1 commit into
samyferhat wants to merge 1 commit into
Conversation
Sass emits an extended placeholder at the location of its definition. The %drawer-css-vars placeholder was defined before @layer components. Thus the drawer token rule was unlayered, and overrides in @layer custom had no effect. Move the placeholder into the layer, like the tokens of the other components. Fixes twbs#43044 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
julien-deramond
added
v6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
%drawer-css-varsplaceholder into@layer componentsinscss/_drawer.scss..drawer, .sm:drawer, …token rule moves into@layer components. No selector or declaration changes.Motivation & Context
@layer components, so the drawer tokens were unlayered.@layer customhad no effect.@layer custom { .drawer { --drawer-width: 321px; } }: before,400px; after,321px. Same result for.lg:drawer.npm run lint,npm run css-test, andnpm run distpass locally.Type of changes
Checklist
npm run lint)Live previews
Related issues
Fixes #43044
🤖 Generated with Claude Code