Repository navigation
Stop closed dialogs from making the page scroll - #43137
Open
samyferhat wants to merge 1 commit into
Open
samyferhat wants to merge 1 commit into
samyferhat wants to merge 1 commit into
Conversation
A closed .dialog uses display: flex for the exit animation, so it keeps its box. The UA sets position: absolute on a closed <dialog>. A tall closed dialog thus adds scrollable overflow, and the page shows a scrollbar. Use position: fixed while the dialog is closed. A fixed box does not add scrollable overflow. The open states do not change. Fixes twbs#43128 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
position: fixedon.dialog:not([open])inscss/_dialog.scss.Motivation & Context
.dialogsetsdisplay: flexso the exit animation works. Thus a closed dialog keeps its box.position: absoluteon a closed<dialog>. A tall closed dialog adds scrollable overflow, and the page shows a scrollbar.npm run lint,npm run css-test, andnpm run distpass locally.Type of changes
Checklist
npm run lint)Live previews
Related issues
Fixes #43128
🤖 Generated with Claude Code