Repository navigation
Docs: document the menu option in the Menu options table - #43140
Merged
Merged
Conversation
Menu accepts a menu element, but the options table omits it. Users have no way to find out they can point a toggle at a menu that is not its sibling.
julien-deramond
self-requested a review
October 21, 2026 17:17
julien-deramond
approved these changes
Oct 21, 2026
julien-deramond
left a comment
Member
There was a problem hiding this comment.
Thanks @ump45nose, good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
menurow to the Options table in the Menu docs.floatingConfigandplacement, the same order as inDefault.Motivation & Context
Menuaccepts amenuoption, and it is not documented.js/src/menu.ts:113declares it in the component config type (menu: HTMLElement | null),:128setsmenu: nullinDefault,:143types it as'(null|element)', and:184uses it:this._menu = (this._config.menu || this._findMenu())._findMenu()(:296-303) looks for.menuafter the toggle, then before it, then inside the wrapper. So a menu that is not a sibling of the toggle, or a wrapper that holds more than one.menu, cannot be handled from the config.Type of changes
Checklist
npm run lint) — see the note belowLive previews
site/src/content/docs/components/menu.mdx, Components → Menu → Options)Notes on verification
markdownlint --config .markdownlint.json site/src/content/docs/components/menu.mdx→ exit 0.docs-prettier-checkdoes not apply:.prettierignorelistssite/src/content/**/*.mdx.npm run lint/npm run docs-buildhere — this checkout has nonode_modulesinstalled. So the checkbox above is left unticked on purpose.Related issues
None. I found the gap by comparing the Options table with
Default/DefaultTypeinjs/src/menu.ts.This PR was prepared with AI assistance (Claude Code). I verified each citation against the source myself and own the wording.