Skip to content

Document Klein integration with Twisted services - #973

Closed
ac1982 wants to merge 2 commits into
twisted:trunkfrom
ac1982:docs/twisted-service-integration
Closed

ac1982 wants to merge 2 commits into
twisted:trunkfrom
ac1982:docs/twisted-service-integration

Conversation

@ac1982

@ac1982 ac1982 commented Oct 20, 2026

Copy link
Copy Markdown

Users integrating Klein into an existing Twisted application currently need to infer how resource(), Site and a server service fit together. Add a runnable .tac example using TCPServer and Application, and explain how to attach it to an existing parent service.

The alternative-running guide now distinguishes obtaining a resource from starting a listener and reactor, and links to the service example. The example is included directly in the documentation and covers foreground startup and shutdown.

Fixes #757 (the workflow reported in #753).

Validation: ran the unmodified example with twistd, checked HTTP 200 and the response body, then sent SIGINT and verified the listener and PID file were removed. The 96 app/resource Trial tests pass on Python 3.12/Twisted 26.4. Sphinx HTML builds successfully using the project's command; a stricter -W build reports the same seven warnings as a clean base checkout, all in the existing theme/forms documentation. No full version matrix or external linkcheck was run.

@glyph

glyph commented Oct 20, 2026

Copy link
Copy Markdown
Member
  • first time contributor
  • reads like slop
    • incoherent reference to "validations" and tests even though this is a doc fix
  • picked up easy issue with no previous project involvement
  • failed to run pre-commit
  • agentscan says automation signals
  • pangram & gptzero both agree 100% AI description

such a slam dunk clear cut case that it doesn't seem worth discussing, banning this user

we do need to get the AI policy linked up here in a PR template for an additional easy signal. for reference: https://docs.twisted.org/en/latest/development/ai-policy.html

@glyph glyph closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add some documentation explaining alternative deployment strategies

2 participants