Repository navigation
Conversation
Member
such a slam dunk clear cut case that it doesn't seem worth discussing, banning this user we do need to get the AI policy linked up here in a PR template for an additional easy signal. for reference: https://docs.twisted.org/en/latest/development/ai-policy.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users integrating Klein into an existing Twisted application currently need to infer how
resource(),Siteand a server service fit together. Add a runnable.tacexample usingTCPServerandApplication, and explain how to attach it to an existing parent service.The alternative-running guide now distinguishes obtaining a resource from starting a listener and reactor, and links to the service example. The example is included directly in the documentation and covers foreground startup and shutdown.
Fixes #757 (the workflow reported in #753).
Validation: ran the unmodified example with
twistd, checked HTTP 200 and the response body, then sent SIGINT and verified the listener and PID file were removed. The 96 app/resource Trial tests pass on Python 3.12/Twisted 26.4. Sphinx HTML builds successfully using the project's command; a stricter-Wbuild reports the same seven warnings as a clean base checkout, all in the existing theme/forms documentation. No full version matrix or external linkcheck was run.