Repository navigation
Conversation
reardonj
commented
Oct 8, 2026
| case _ => | ||
| handshakeMutex.lock | ||
| .surround(stepHandshake(result, true)) >> wrap | ||
| // TODO: is this the right way to use and close the resource? |
Contributor
Author
There was a problem hiding this comment.
I'm not quite sure how resources are scoped in a Pull. Is this right?
Adds support to write to a socket while reporting incrementally how many bytes were written, so that writing a large buffer can be monitored as it progresses. For simpler implementations, I have just duplicated them and varied to support responding with a stream. For the more complicated ones, I have modified the main implementation to be writeIncremental so to avoid introducing duplicating the code.
reardonj
force-pushed
the
3773-write-progress
branch
from
October 8, 2026 02:15
cf0fc87 to
39db941
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to write to a socket while reporting incrementally how many bytes were written, so that writing a large buffer can be monitored as it progresses. For simpler implementations, I have just duplicated them and varied to support responding with a stream. For the more complicated ones, I have modified the main implementation to be writeIncremental so to avoid introducing duplicating the code.
Fixes #3773