Repository navigation
fix(config): enclose IPv6 node hosts in brackets when building the URL - #155
Open
RaphaelFakhri wants to merge 3 commits into
Open
RaphaelFakhri wants to merge 3 commits into
RaphaelFakhri wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Node.url()builds the node URL as{protocol}://{host}:{port}{path}. When the host is an IPv6 literal, the result (for example,http://::1:8108) is not a valid URL, and every request fails withhttpx.InvalidURL: Invalid port.This affects both node formats:
"http://[::1]:8108", becauseNode.from_urlstoresurlparse(url).hostname, which drops the brackets.{"host": "::1", "port": 8108, "protocol": "http"}.Node.url()now encloses a host that contains:in brackets, unless the host is already bracketed. IPv4 and hostname nodes produce the same URL as before.Tests added in
tests/node_test.py:test_node_url_ipv6_hosttest_node_url_bracketed_ipv6_hosttest_node_from_url_ipv6The first and third fail on
masterand pass with this change.PR checklist
ruff checkandmypy src/typesensepass.Fixes #154