Skip to content

fix(stovepipe): Track validations in order - #1010

Merged
prathshenoy merged 1 commit into
prath/request-build-associationfrom
prath/ordered-issue-tracking
Nov 6, 2026
Merged

fix(stovepipe): Track validations in order#1010
prathshenoy merged 1 commit into
prath/request-build-associationfrom
prath/ordered-issue-tracking

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

What:

  • Apply issue updates in request order while builds and analysis continue concurrently.

Why:

  • Prevent newer refreshes from discarding an earlier validation’s delayed final results. This can leave old failures open and prevent newly detected failures from being tracked.
  • Preserve distinct issue occurrences in history and repair selection. A clean validation must close an earlier opening before the next validation can reopen the same failure and trigger a new repair.

Test Plan

  • Add unit tests.
  • Verify queue-head blocking and storage updates against MySQL.
  • Verify issue-tracking completion and DLQ recovery end-to-end.

Revert Plan

  • Pause admission and finish or safely abandon the new tracking jobs before reverting. Keep the additive database column; older code can ignore it.

Issue Links

Stack

  1. fix(stovepipe): Retain request build associations #1011
  2. fix(stovepipe): Track validations in order #1010

@prathshenoy
prathshenoy changed the base branch from main to prath/request-build-association November 4, 2026 21:06
@prathshenoy
prathshenoy force-pushed the prath/ordered-issue-tracking branch from 2164754 to 0caae0b Compare November 4, 2026 21:06
@prathshenoy prathshenoy mentioned this pull request Nov 4, 2026
Merged
1 task done
@prathshenoy
prathshenoy force-pushed the prath/ordered-issue-tracking branch 2 times, most recently from 250f381 to 4ac9918 Compare November 5, 2026 16:25
@prathshenoy
prathshenoy added this pull request to stack #1016 November 5, 2026 16:26
@prathshenoy
prathshenoy force-pushed the prath/ordered-issue-tracking branch 4 times, most recently from ff46709 to ae3d7a2 Compare November 5, 2026 18:51
@prathshenoy
prathshenoy removed this pull request from stack #1016 November 5, 2026 19:02
@prathshenoy
prathshenoy changed the base branch from prath/request-build-association to prath/process-admission-cleanup November 5, 2026 19:02
@prathshenoy
prathshenoy force-pushed the prath/ordered-issue-tracking branch from ae3d7a2 to d507468 Compare November 5, 2026 19:02
@prathshenoy
prathshenoy added this pull request to stack #1019 November 5, 2026 19:02
@prathshenoy prathshenoy mentioned this pull request Nov 5, 2026
Closed
1 task done
@prathshenoy
prathshenoy removed this pull request from stack #1019 November 5, 2026 19:39
@prathshenoy
prathshenoy changed the base branch from prath/process-admission-cleanup to prath/request-build-association November 5, 2026 19:39
@prathshenoy
prathshenoy force-pushed the prath/ordered-issue-tracking branch from d507468 to 1bda7e8 Compare November 5, 2026 19:40
@prathshenoy
prathshenoy added this pull request to stack #1020 November 5, 2026 19:40
@prathshenoy
prathshenoy marked this pull request as ready for review November 5, 2026 20:03
@prathshenoy
prathshenoy force-pushed the prath/ordered-issue-tracking branch 2 times, most recently from f3a8a14 to c28cb73 Compare November 6, 2026 16:47
@prathshenoy
prathshenoy force-pushed the prath/ordered-issue-tracking branch from c28cb73 to 3c64766 Compare November 6, 2026 17:35
@prathshenoy
prathshenoy force-pushed the prath/ordered-issue-tracking branch from 3c64766 to 3643b1d Compare November 6, 2026 17:36
@prathshenoy
prathshenoy added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit abe0c9f Nov 6, 2026
22 checks passed
@prathshenoy
prathshenoy deleted the prath/ordered-issue-tracking branch November 6, 2026 18:10
DivyanshGarg380 pushed a commit to DivyanshGarg380/submitqueue that referenced this pull request Nov 6, 2026
@prathshenoy
fix(stovepipe): Retain request build associations (uber#1011)
cf86b5c 
## Summary
**What**:
- Save each request’s build association before handing the build to
status polling and analysis.
- Reuse the associated build when dispatch is retried.

**Why**:
- Let work registered before build dispatch find the build while it is
running. Previously, the request only identified its build after
completion, so ordered issue tracking could not follow a running
validation.
- Avoid starting another build when retrying a handoff after the
association was saved. A crash before saving it can still create a
duplicate, so this does not guarantee exactly one CI build.

## Test Plan
- [x] Add unit tests.

## Revert Plan
- Revert the dependent tracking change first, then revert this PR. Keep
the additive database column; older code can ignore it. Provision the
column before deploying this change.

## Issue Links
-
[CODEM-607](https://linear.app/uber/issue/CODEM-607/build-analysis-issue-track)

## Stack
1. uber#1011
1. uber#1010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnoah1 mnoah1 mnoah1 approved these changes
@behinddwalls behinddwalls Awaiting requested review from behinddwalls behinddwalls is a code owner
@sbalabanov sbalabanov Awaiting requested review from sbalabanov sbalabanov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prathshenoy @mnoah1