Skip to content

feat(orch): Consume hook events - #608

Open
prathshenoy wants to merge 1 commit into
prath.shenoy/hook-dispatchfrom
prath.shenoy/hook-wiring
Open

feat(orch): Consume hook events#608
prathshenoy wants to merge 1 commit into
prath.shenoy/hook-dispatchfrom
prath.shenoy/hook-wiring

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

What:

  • Consume lifecycle events from the queue and hand each one to the integration the deployment wires, accepting and discarding them while no integration is attached.
  • Reconcile the matching dead-letter queue so events that fail every retry are recorded and alerted on instead of accumulating unread.

Why:

  • Prove the delivery path end to end before anything produces an event, so a later change adds producers to a route that already works.
  • Keep a deployment with no integrations configured distinguishable from one that is silently losing events.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. Since nothing publishes hook events yet and the wired hook is a no-op, no side effect is lost.

Issues

Stack

  1. feat(hook): Add contract for lifecycle events #606
  2. feat(hook): Deliver events to integrations #607
  3. @ feat(orch): Consume hook events #608

@prathshenoy
prathshenoy marked this pull request as ready for review August 18, 2026 00:30
@prathshenoy prathshenoy changed the title feat(orchestrator): Consume hook events feat(orch): Consume hook events Aug 18, 2026

@mnoah1 mnoah1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-up - you can wire this into stovepipe both here, and within our internal service.

behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Aug 19, 2026
## Summary
**What**:
- Define the shared event format every domain publishes for
fire-and-forget lifecycle notifications, carrying origin, type, timing,
a staleness marker, and open per-event detail.
- Derive an event's identity from the transition it describes, so
replaying a transition produces the same identity and duplicate
deliveries collapse.

**Why**:
- Enable integrations to react to pipeline milestones without adding
call sites that can stall or fail a merge.
- Establish one schema and one identity rule before any producer ships,
so a consumer spanning several domains needs only one reader.

## Test Plan
- [x] Add unit tests.

## Revert Plan
- Revert this PR. No topic is registered and no message of this shape
exists on any queue.

## Issues
-
[CODEM-416](https://linear.app/uber/issue/CODEM-416/hooks-integration-downstream-notificaiton)

## Stack
1. @ uber#606
1. uber#607
1. uber#608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants