Skip to content

refactor(git): relocate platform/gitexec under platform/git #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
behinddwalls merged 1 commit into from
Aug 19, 2026
Merged

refactor(git): relocate platform/gitexec under platform/git #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion platform/gitexec/BUILD.bazel → platform/git/exec/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ load("@rules_go//go:def.bzl", "go_library")
go_library(
name = "go_default_library",
srcs = ["gitexec.go"],
importpath = "github.com/uber/submitqueue/platform/gitexec",
importpath = "github.com/uber/submitqueue/platform/git/exec",
visibility = ["//visibility:public"],
)
0 platform/gitexec/gitexec.go → platform/git/exec/gitexec.go
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion platform/gitexec/gitexectest/BUILD.bazel → platform/git/exectest/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ load("@rules_go//go:def.bzl", "go_library")
go_library(
name = "go_default_library",
srcs = ["gitexectest.go"],
importpath = "github.com/uber/submitqueue/platform/gitexec/gitexectest",
importpath = "github.com/uber/submitqueue/platform/git/exectest",
visibility = ["//visibility:public"],
deps = ["@com_github_stretchr_testify//require:go_default_library"],
)
0 platform/gitexec/gitexectest/gitexectest.go → platform/git/exectest/gitexectest.go
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion runway/extension/merger/git/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ go_test(
"//api/base/mergestrategy/protopb:go_default_library",
"//api/runway/messagequeue:go_default_library",
"//api/runway/messagequeue/protopb:go_default_library",
"//platform/gitexec/gitexectest:go_default_library",
"//platform/git/exectest:go_default_library",
"//runway/extension/merger:go_default_library",
"@com_github_stretchr_testify//assert:go_default_library",
"@com_github_stretchr_testify//require:go_default_library",
Expand Down
2 changes: 1 addition & 1 deletion runway/extension/merger/git/git_merger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import (
mergestrategypb "github.com/uber/submitqueue/api/base/mergestrategy/protopb"
runwaymq "github.com/uber/submitqueue/api/runway/messagequeue"
runwaypb "github.com/uber/submitqueue/api/runway/messagequeue/protopb"
"github.com/uber/submitqueue/platform/gitexec/gitexectest"
gitexectest "github.com/uber/submitqueue/platform/git/exectest"
"github.com/uber/submitqueue/runway/extension/merger"
)

Expand Down
2 changes: 1 addition & 1 deletion service/runway/server/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ go_test(
},
deps = [
"//api/base/mergestrategy/protopb:go_default_library",
"//platform/gitexec/gitexectest:go_default_library",
"//platform/git/exectest:go_default_library",
"//runway/extension/merger/git:go_default_library",
"@com_github_stretchr_testify//assert:go_default_library",
"@com_github_stretchr_testify//require:go_default_library",
Expand Down
2 changes: 1 addition & 1 deletion service/runway/server/checkout_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"

"github.com/uber/submitqueue/platform/gitexec/gitexectest"
gitexectest "github.com/uber/submitqueue/platform/git/exectest"
gitmerger "github.com/uber/submitqueue/runway/extension/merger/git"
)

Expand Down
6 changes: 3 additions & 3 deletions service/submitqueue/demo/requests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ go_library(
"//platform/base/change/git:go_default_library",
"//platform/base/change/github:go_default_library",
"//platform/fakemarker:go_default_library",
"//platform/gitexec:go_default_library",
"//platform/git/exec:go_default_library",
"//submitqueue/client:go_default_library",
"@org_golang_x_sync//errgroup:go_default_library",
],
Expand Down Expand Up @@ -48,8 +48,8 @@ go_test(
deps = [
"//platform/base/change/git:go_default_library",
"//platform/fakemarker:go_default_library",
"//platform/gitexec:go_default_library",
"//platform/gitexec/gitexectest:go_default_library",
"//platform/git/exec:go_default_library",
"//platform/git/exectest:go_default_library",
"@com_github_stretchr_testify//assert:go_default_library",
"@com_github_stretchr_testify//require:go_default_library",
],
Expand Down
2 changes: 1 addition & 1 deletion service/submitqueue/demo/requests/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
"sync"

gitchange "github.com/uber/submitqueue/platform/base/change/git"
"github.com/uber/submitqueue/platform/gitexec"
gitexec "github.com/uber/submitqueue/platform/git/exec"
"github.com/uber/submitqueue/submitqueue/client"
)

Expand Down
2 changes: 1 addition & 1 deletion service/submitqueue/demo/requests/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ import (
"time"

mergestrategypb "github.com/uber/submitqueue/api/base/mergestrategy/protopb"
"github.com/uber/submitqueue/platform/gitexec"
gitexec "github.com/uber/submitqueue/platform/git/exec"
"github.com/uber/submitqueue/submitqueue/client"
"golang.org/x/sync/errgroup"
)
Expand Down
4 changes: 2 additions & 2 deletions service/submitqueue/demo/requests/source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ import (
"github.com/stretchr/testify/require"
gitchange "github.com/uber/submitqueue/platform/base/change/git"
"github.com/uber/submitqueue/platform/fakemarker"
"github.com/uber/submitqueue/platform/gitexec"
"github.com/uber/submitqueue/platform/gitexec/gitexectest"
gitexec "github.com/uber/submitqueue/platform/git/exec"
gitexectest "github.com/uber/submitqueue/platform/git/exectest"
)

// quietSpec is a changeSpec whose progress notes go nowhere, for tests that
Expand Down
2 changes: 1 addition & 1 deletion service/submitqueue/orchestrator/server/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ go_test(
},
deps = [
"//platform/base/change:go_default_library",
"//platform/gitexec/gitexectest:go_default_library",
"//platform/git/exectest:go_default_library",
"//submitqueue/entity:go_default_library",
"//submitqueue/extension/buildrunner:go_default_library",
"//submitqueue/extension/changeprovider:go_default_library",
Expand Down
2 changes: 1 addition & 1 deletion service/submitqueue/orchestrator/server/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
"go.uber.org/zap/zaptest"

"github.com/uber/submitqueue/platform/base/change"
"github.com/uber/submitqueue/platform/gitexec/gitexectest"
gitexectest "github.com/uber/submitqueue/platform/git/exectest"
"github.com/uber/submitqueue/submitqueue/entity"
"github.com/uber/submitqueue/submitqueue/extension/changeprovider"
"github.com/uber/submitqueue/submitqueue/extension/conflict"
Expand Down
2 changes: 1 addition & 1 deletion submitqueue/extension/changeprovider/git/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ go_test(
},
deps = [
"//platform/base/change:go_default_library",
"//platform/gitexec/gitexectest:go_default_library",
"//platform/git/exectest:go_default_library",
"//submitqueue/entity:go_default_library",
"//submitqueue/extension/changeprovider:go_default_library",
"@com_github_stretchr_testify//assert:go_default_library",
Expand Down
2 changes: 1 addition & 1 deletion submitqueue/extension/changeprovider/git/provider_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
"go.uber.org/zap"

"github.com/uber/submitqueue/platform/base/change"
"github.com/uber/submitqueue/platform/gitexec/gitexectest"
gitexectest "github.com/uber/submitqueue/platform/git/exectest"
"github.com/uber/submitqueue/submitqueue/entity"
"github.com/uber/submitqueue/submitqueue/extension/changeprovider"
)
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/submitqueue/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ go_test(
"//platform/extension/consumergate:go_default_library",
"//platform/extension/consumergate/file:go_default_library",
"//platform/extension/messagequeue/mysql:go_default_library",
"//platform/gitexec/gitexectest:go_default_library",
"//platform/git/exectest:go_default_library",
"//platform/publish:go_default_library",
"//submitqueue/core/batch:go_default_library",
"//submitqueue/core/topickey:go_default_library",
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/submitqueue/git_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ import (
changepb "github.com/uber/submitqueue/api/base/change/protopb"
mergestrategypb "github.com/uber/submitqueue/api/base/mergestrategy/protopb"
gatewaypb "github.com/uber/submitqueue/api/submitqueue/gateway/protopb"
"github.com/uber/submitqueue/platform/gitexec/gitexectest"
gitexectest "github.com/uber/submitqueue/platform/git/exectest"
"github.com/uber/submitqueue/submitqueue/entity"
"github.com/uber/submitqueue/test/testutil"
"google.golang.org/grpc"
Expand Down
6 changes: 3 additions & 3 deletions tool/gitsandbox/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go_library(
srcs = ["main.go"],
importpath = "github.com/uber/submitqueue/tool/gitsandbox",
visibility = ["//visibility:private"],
deps = ["//platform/gitexec:go_default_library"],
deps = ["//platform/git/exec:go_default_library"],
)

go_binary(
Expand All @@ -31,8 +31,8 @@ go_test(
"SUBMITQUEUE_TEST_GIT": "$(location @git//:git)",
},
deps = [
"//platform/gitexec:go_default_library",
"//platform/gitexec/gitexectest:go_default_library",
"//platform/git/exec:go_default_library",
"//platform/git/exectest:go_default_library",
"@com_github_stretchr_testify//assert:go_default_library",
"@com_github_stretchr_testify//require:go_default_library",
],
Expand Down
2 changes: 1 addition & 1 deletion tool/gitsandbox/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (
"os"
"path/filepath"

"github.com/uber/submitqueue/platform/gitexec"
gitexec "github.com/uber/submitqueue/platform/git/exec"
)

// seedFile is committed so the target branch exists with something on it. A
Expand Down
4 changes: 2 additions & 2 deletions tool/gitsandbox/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ import (

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/uber/submitqueue/platform/gitexec"
"github.com/uber/submitqueue/platform/gitexec/gitexectest"
gitexec "github.com/uber/submitqueue/platform/git/exec"
gitexectest "github.com/uber/submitqueue/platform/git/exectest"
)

func TestProvision_SeedsABareRepositoryOnTheTargetBranch(t *testing.T) {
Expand Down
Loading