fix(errs): Retry transient grouped failures - #621
Open
prathshenoy wants to merge 2 commits into
Open
Conversation
prathshenoy
marked this pull request as ready for review
August 19, 2026 19:23
prathshenoy
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
August 19, 2026 19:23
prathshenoy
enabled auto-merge
August 19, 2026 19:23
mnoah1
reviewed
Aug 19, 2026
| // no classifier is invoked. Pass 2 runs the configured classifiers per node. | ||
| // Walking the chain is cheap relative to a classifier call, so this avoids | ||
| // running classifiers whenever the chain is already classified deeper down. | ||
| // Implementation: two passes over the chain. Pass 1 looks for an existing |
Contributor
There was a problem hiding this comment.
What if instead, we just create errs.Group(errors...) and let controllers return that to group errors:
- Iternal groupedError type with members[]
- when it's a grouped error, each member gets passed through Process, which gets its classification
- the whole thing gets wrapped as retryable if any of them are retryable
Would be a bit more explicit than trying to unwrap from the results returned by errors.Join
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What:
Why:
Test Plan
Revert Plan
Issues