Repository navigation
compiler: fix endless loop on syntax errors in template placeholders - #498
Merged
Merged
Conversation
When the expression within a template literal placeholder is cut short
by a syntax error, e.g. `${ 1 2 }`, or by the end of the source, the
statement end marker of the placeholder expression has already advanced
the source position beyond the last token of the expression when the
instruction storing the result is emitted for that token.
Since source positions are encoded as unsigned deltas, the position
going backwards turned into an enormous offset which uc_chunk_add()
spent nearly forever and a lot of memory on, as the assertion guarding
the invariant is compiled out in release builds.
Tolerate positions in front of the current one once a syntax error has
occurred, the generated code is discarded anyway.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the expression within a template literal placeholder is cut short by a syntax error, e.g.
${ 1 2 }, or by the end of the source, the statement end marker of the placeholder expression has already advanced the source position beyond the last token of the expression when the instruction storing the result is emitted for that token.Since source positions are encoded as unsigned deltas, the position going backwards turned into an enormous offset which uc_chunk_add() spent nearly forever and a lot of memory on, as the assertion guarding the invariant is compiled out in release builds.
Tolerate positions in front of the current one once a syntax error has occurred, the generated code is discarded anyway.