fix(registry): add explicit width to ColorDropdownMenuItems to prevent dropdown clipping (#5052) - #5079
Closed
Samarth1306w wants to merge 1 commit into
Closed
Conversation
…t dropdown clipping (#5052) When font or background color picker dropdown was opened in a narrow toolbar, ColorDropdownMenuItems's 10-column grid clipped horizontally because no explicit width was set on the grid container. Fix: - Add w-[276px] to ColorDropdownMenuItems grid container in font-color-toolbar-button.tsx. - Add patch changeset for registry UI. Closes #5052
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 8bd1a99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Fixes #5052 — Font colour toolbar component has fragile dropdown sizing.
🔍 Root Cause Analysis
When opening the font color or background color picker dropdown in a toolbar with constrained width,
ColorDropdownMenuItems's 10-column grid (grid-cols-[repeat(10,1fr)]) lacked an explicit container width, causing the color items to shrink and clip horizontally.🛠️ Surgical Patch Breakdown
apps/www/src/registry/ui/font-color-toolbar-button.tsx:Added explicit width (
w-[276px]) toColorDropdownMenuItems's grid container so all 10 color columns allocate full required width without horizontal clipping..changeset/fix-font-color-toolbar-button-dropdown-width.md: Added patch changeset for registry UI.🧪 Verification & Test Coverage
ColorDropdownMenuItemsallocates exact 276px container width for all 10 color swatches + gaps.wwwregistry UI.mainwith 0 conflicts.