fix(www): memoize plugins array in playground demo to eliminate typing latency (#5066) - #5080
Closed
Samarth1306w wants to merge 1 commit into
Closed
Conversation
…g latency (#5066) In PlaygroundDemo, spreading plugin arrays inline inside usePlateEditor options passed a new plugins array reference on every render, causing usePlateEditor to re-initialize the plugin registry on every keystroke. Fix: - Extract basePlugins array outside PlaygroundDemo component. - Memoize plugins array and overrideEnabled config with React.useMemo. - Add patch changeset for www app. Closes #5066
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
dosubot
Bot
added
size:M
🦋 Changeset detectedLatest commit: c6cb5bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Fixes #5066 — Homepage editor typing is visibly slow on next.
🔍 Root Cause Analysis
In
apps/www/src/registry/examples/playground-demo.tsx, spreading plugin arrays inline insideusePlateEditoroptions passed a brand newpluginsarray reference on every render. BecausePlaygroundDemorenders on every typing keystroke,usePlateEditorre-initialized and re-bound the plugin registry on every input event, creating noticeable typing latency.🛠️ Surgical Patch Breakdown
apps/www/src/registry/examples/playground-demo.tsx:basePluginsarray outsidePlaygroundDemo.pluginsarray andoverrideEnabledoptions withReact.useMemosousePlateEditorreceives a stable reference..changeset/fix-homepage-playground-plugin-memoization.md: Added patch changeset for www app.🧪 Verification & Test Coverage
usePlateEditorfrom re-compiling the plugin registry on every keystroke render.wwwapp.nextwith 0 conflicts.