feat(ssh): agent timeout for passphrase-protected keys - #68
Merged
Merged
Conversation
The fence matches path strings literally and Linux is case-sensitive, so "~/Bitbucket" never covered the actual ~/bitbucket checkouts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
When a passphrase is set, prompt for how long ssh-agent keeps the key unlocked (minutes, default 15; 0 = never cache, ask on every use). The generated Host block gets a matching AddKeysToAgent interval so keys re-added on first use expire too, instead of staying unlocked forever. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_ssh_key.shnow prompts for how longssh-agentkeeps the key unlocked — minutes, default 15,0= never cache (passphrase asked on every use). The key is added withssh-add -t Nm, and the generatedHostblock writes a matchingAddKeysToAgent Nm(ornofor0) so keys re-added on first use expire too instead of staying unlocked forever. Keys without a passphrase behave exactly as before. Pre-fillable viaAGENT_TIMEOUT=N; README updated.~/bitbucketdev root. The fence matches path strings literally and Linux is case-sensitive, so the existing~/Bitbucketentry never covered the actual lowercase checkouts.denied_pathsstill takes precedence.Carried over from the merged
feat/linux-benchmarkingbranch's working tree. A localdriftcheck.shedit was dropped as already merged in improved form (cf23033).Testing
shellcheck --severity=warningandbash -nclean.ssh-add -t 15m/-t 1magainst a real passphrase-protected ed25519 key (lifetimes 900s/60s confirmed)./security-reviewpass: no findings —AGENT_TIMEOUTis validated digits-only before reachingssh-add/ssh_config, and every branch is at least as tight as the old no-lifetimessh-add.🤖 Generated with Claude Code