Repository navigation
operator: give UDP gateway listeners their own name so TCP can share the port - #53
Merged
Merged
Conversation
…the port L4 listeners were all named l4-<nodePort>. So a service exposing TCP and UDP on the same port produced two Gateway listeners with the same name, and the two routes pointed at the same section. UDP listeners are now named l4-udp-<nodePort>. TCP listeners keep their existing l4-<nodePort> name so current gateways and TCPRoutes don't change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every L4 Gateway listener was named
l4-<nodePort>. When a service exposed TCP and UDP on the same port, the Gateway got two listeners with the same name, and the TCPRoute and UDPRoute both pointed at the same section.l4-udp-<nodePort>, and the UDPRoute'ssectionNamepoints at that listener.l4-<nodePort>, so existing Gateways and TCPRoutes stay the same.Addresses UNB-465.
Testing
TestGatewayL4TCPAndUDPOnSamePort. It builds routes for a service with TCP and UDP both on port 8388. It checks that the Gateway has anl4-8388TCP listener and anl4-udp-8388UDP listener, and that each route points at its own listener.