Add a step to build base image locally - #94
Merged
srmanda-cs merged 12 commits intoAug 18, 2026
Conversation
Updated Maven command to specify pom.xml for building the base image.
There was a problem hiding this comment.
Pull request overview
This PR updates the container integration test GitHub Actions workflow to build the gdcc/base container image locally before building the Dataverse application/container images, aiming to avoid failures when the expected base image tag is not available from a remote registry.
Changes:
- Added a new workflow step to build the
modules/container-baseimage/module before the main container build. - Minor formatting/whitespace adjustment in the artifact upload section.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+78
to
+80
| set -euo pipefail | ||
| echo "Building the base image module so it is cached locally..." | ||
| mvn -Pct clean package -pl modules/container-base |
Added step to build local base image for caching.
Updated the workflow to fetch or build the base image based on its availability in the registry.
Updated workflow to fetch or build the base image based on availability in the registry.
Updated the workflow to change the directory before evaluating the base image and added safety checks for image evaluation.
Updated the process for fetching or building the local base image in the CI workflow. Added a safety check for unresolved variables and modified the Maven command to ensure proper evaluation of the base image tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: