fix(crawler): await inner stream aclose in arun_many (#2083) - #2198
Open
Battleplus wants to merge 1 commit into
Open
fix(crawler): await inner stream aclose in arun_many (#2083)#2198Battleplus wants to merge 1 commit into
Battleplus wants to merge 1 commit into
Conversation
When the outer result_transformer() generator is closed via aclose(), the inner dispatcher.run_urls_stream() generator was not explicitly closed, so its cleanup (task cancellation, session release) could overlap with session teardown. Explicitly aclose() the inner generator in the finally block before releasing the session. Closes unclecode#2083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2083 — When the outer result_transformer() generator is closed via aclose(), the inner dispatcher.run_urls_stream() generator was not explicitly closed, so its cleanup could overlap with session teardown.
Fix
Explicitly aclose() the inner generator in the finally block before releasing the session.
Files changed