fix: ensure dispatcher cleanup on crawler shutdown - #2209
Open
rozin-not-found wants to merge 3 commits into
Open
fix: ensure dispatcher cleanup on crawler shutdown#2209rozin-not-found wants to merge 3 commits into
rozin-not-found wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2083.
This PR resolves a task/memory leak that occurs when
AsyncWebCrawler.arun_many()breaks early during a stream. Because Python delays finalization of async generators, relying on the generator'sfinallyblock caused race conditions (RuntimeError: aclose(): asynchronous generator is already running). This PR implements a crawler-level dispatcher tracking system that explicitly forces a native cleanup during the crawler's teardown phase.List of files changed and why
crawl4ai/async_webcrawler.py: Added dispatcher tracking (self._dispatchers) toAsyncWebCrawlerand updated the teardown phase to enforce cleanup on shutdown.crawl4ai/async_dispatcher.py: Implemented a nativecleanup()method inMemoryAdaptiveDispatcherto explicitly cancel active tasks and stop the memory monitor.How Has This Been Tested?
len(asyncio.all_tasks())before starting the crawler and after theasync withcontext manager exits.async forloop overarun_many(stream=True)correctly clears all background tasks.ResourceWarningis completely eliminated.Checklist: