Repository navigation
feat: add loading and error fallbacks - #83
Open
arpittkhandelwal wants to merge 2 commits into
Open
arpittkhandelwal wants to merge 2 commits into
arpittkhandelwal wants to merge 2 commits into
Conversation
|
@arpittkhandelwal is attempting to deploy a commit to the Unlayer Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents the blank editor container shown while the CDN embed script and editor instance are initializing, and gives host applications control over the loading and initialization-error experience.
Closes #82
What changed
loadingFallback?: ReactNodefor a custom loading spinner, skeleton, image, or branded UI.errorFallback?: ReactNode | ((error, retry) => ReactNode)for a custom initialization-error experience.role="status"with “Loading image editor…”role="alert"with a “Try again” buttonloadorerrorleft the component loading forever and made retry unreachable. The timed-out tag is removed so retry starts fresh.Example
Backward compatibility
Existing
ImageEditorusage is unchanged. Consumers who do not pass fallbacks receive sensible default loading and retryable error UI instead of a blank surface.Verification
npm test— 51 tests passingnpm run typechecknpm run lintnpm run build