Conversation
|
@Anand-240 is attempting to deploy a commit to the Unlayer Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Thanks for this, and for the clear write-up in #87. The image editor doesn't have a change event today, so this We'll discuss whether to add a change event to the editor and update you here. In the meantime, let's keep this PR open as a draft. Until then, polling |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live previews currently have to poll
hasChanges()andgetImage()to detect edits. This draft proposes the React side of an image change callback for #87.The component forwards
MountOptions.onChangeto the latestonChangeprop without remounting, polling, or exporting an image. Notifications from a cancelled mount are ignored. The callback is excluded fromoptions, consistent with the other component callbacks.Core dependency
The default CDN editor, version 2.13.0, does not emit this callback. This draft needs a corresponding change in the underlying editor before it can replace polling or be released. It does not close #87.
The proposed contract is a notification when the visible image changes. Consumers control snapshot timing and throttling. The core implementation needs to define notifications during brush strokes, undo, redo, adjustments, and resets, and ensure the current image can be read when the callback runs. Tool selection and viewport changes should not trigger it.
Validation