Skip to content

chore: remove method for /api/v1/userAgents #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ninoseki wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: remove method for /api/v1/userAgents #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d54b3e
chore: remove method for /api/v1/userAgents
ninoseki Sep 11, 2026
295ff1a
test: remove related tests
ninoseki Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/urlscan/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,18 +818,6 @@ def get_available_countries(self) -> dict:
"""
return self.get_json("/api/v1/availableCountries")

def get_user_agents(self) -> dict:
"""Get grouped user agents to use with the Scan API.

Returns:
dict: Available user agents.

Reference:
https://docs.urlscan.io/apis/urlscan-openapi/scanning/getuseragents

"""
return self.get_json("/api/v1/userAgents")

def get_quotas(self) -> dict:
"""Get available and used API quotas.

Expand Down
7 changes: 0 additions & 7 deletions tests/integration/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,6 @@ def test_get_available_countries(client: Client):
assert len(countries) > 0


@pytest.mark.integration
def test_get_user_agents(client: Client):
user_agents = client.get_user_agents()
assert isinstance(user_agents, dict)
assert len(user_agents) > 0


@pytest.mark.integration
def test_get_response(client: Client):
# hash of an empty content/string
Expand Down
26 changes: 0 additions & 26 deletions tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,32 +375,6 @@ def test_get_available_countries(client: Client, httpserver: HTTPServer):
assert got == data


def test_get_user_agents(client: Client, httpserver: HTTPServer):
data = {
"userAgents": [
{
"group": "Chrome",
"useragents": [
"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.131 Safari/537.36"
],
},
{
"group": "iOS",
"useragents": [
"Mozilla/5.0 (iPhone; CPU iPhone OS 14_7_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Mobile/15E148 Safari/604.1"
],
},
]
}
httpserver.expect_request(
"/api/v1/userAgents",
method="GET",
).respond_with_json(data)

got = client.get_user_agents()
assert got == data


def test_get_quotas(client: Client, httpserver: HTTPServer):
data = {
"scope": "team",
Expand Down