Repository navigation
feat(i18n): per-app language in system settings; missing translations warn - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #54. On Android 13+, MarkReader now appears under Settings → Apps → Language, so people can pick its language without changing the whole phone's. Lint also stops failing the build when a new string has no translations yet.
Changes
generateLocaleConfiglists the translated locales in the manifest (android:localeConfig), withen-USas the default viares/resources.properties. The generated config covers English plus the 16 locales from feat(i18n): add European and Slavic localizations #54. Below Android 13 nothing changes: the app follows the device language, as before.MissingTranslationis now a warning. Translations arrive in separate community PRs, so a feature PR can add strings before they're translated, and Android falls back to English at runtime.ExtraTranslationstays an error: a translation of a string that no longer exists is stale and should be deleted with the string.lint.xml.Notes
There's no in-app language picker yet. Below Android 13 that needs AppCompat or locale handling of our own, so it waits for the settings rework.