fix(claude): tag the release with git -c tag.gpgsign=false - #666
Merged
Merged
Conversation
/oddyssey-publish step 4 ran `git tag vX.Y.Z`, which a `tag.gpgsign` git setting turns into a signed annotated tag that fails without a message. Every release tag is lightweight; the command now always creates one, and the release workflow's usage comment says the same. Closes #665 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/oddyssey-publishstep 4 now shows and runsgit -c tag.gpgsign=false tag vX.Y.Z: atag.gpgsigngit setting turned the plaingit tag vX.Y.Zinto a signed annotated tag that fails withfatal: no tag message?(hit while cutting v1.13.2). Every release tag is lightweight, and the release workflow re-points it withgit tag -f. The workflow's usage comment states the same command.Review
A separate reviewer sub-agent reproduced the failure in a throwaway repo with
tag.gpgsign=true, confirmed the new command creates a lightweight tag (also aftergit tag -f), thatrelease.ymlnever checks the tag type, and that no other place states the old command: no finding, ready to merge. Noted out of scope: the manual recovery hint inrelease.yml's error message uses a plaingit tag -f.No harness measurement: the change is a maintainer command and a workflow comment, off the path of
/odd-observe,/odd-verifyand/odd-status.Closes #665
🤖 Generated with Claude Code