add an HRTB to allow trivial bounds to continue to compile - #1
Open
sjwang05 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! This project surfaced while assessing what potential breakage PR rust-lang/rust#159118 would cause to the Rust ecosystem. The PR fixes a bug in the compiler where some unsatisfiable
where-clauses would be allowed to compile without error.Unfortunately, after this fix, this project will no longer compile. To allow it to continue to compile, the simplest workaround that preserves existing functionality is to add a dummy
for<'trivial_bound>binder around the where-clause in question. I've attempted to do such a minimal change in this PR.For reference, the full list of build failures caused by the rustc PR can be found here: https://crater-reports.s3.amazonaws.com/pr-159118/index.html