parser: reject reserved keywords in qualified identifiers#52
Open
Franklin-Qi wants to merge 1 commit into
Open
Conversation
Validate namespace and literal parts of ns::name against gawk's reserved keyword list when building identifiers, including @namespace directives. Closes: uutils#37
Alonely0
reviewed
Jun 17, 2026
Collaborator
There was a problem hiding this comment.
This is nice, but scales very poorly. As I mentioned in the Discord, I have been doing some testing with the other option I had mentioned (separating the path as a different token), and it integrates a lot better with Logos, resulting in a negative diff; I should be able to get it polished by Friday. However, the tests are great and we can keep them. Would you be okay just keeping the tests, so we can merge this after I push? Ty!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate namespace and literal parts of ns::name against gawk's reserved keyword list when building identifiers, including @namespace directives.
Closes: #37