unexpand: accept a blank as a tab-list separator like GNU - #14057
Open
AlejandroCoronadoN wants to merge 1 commit into
Open
unexpand: accept a blank as a tab-list separator like GNU#14057AlejandroCoronadoN wants to merge 1 commit into
AlejandroCoronadoN wants to merge 1 commit into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
|
GNU testsuite comparison: |
oech3
reviewed
Aug 21, 2026
| } | ||
|
|
||
| /// Decide whether the character is either a space or a comma. | ||
| fn is_space_or_comma(c: char) -> bool { |
Contributor
There was a problem hiding this comment.
Not a useful function. Please remove it and write code directly.
AlejandroCoronadoN
force-pushed
the
unexpand-space-tab-separator
branch
from
August 21, 2026 09:41
2a16155 to
80248df
Compare
Contributor
Author
|
Good point, removed the helper and inlined it as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU
unexpandaccepts both a comma and a blank between tab stops in-t/--tabs, sounexpand -t '2 3'behaves likeunexpand -t '2,3'. uutils only splits on a comma, so the space form is rejected:uutils' own
expandalready accepts both separators via anis_space_or_commahelper; onlyunexpandwas inconsistent. This splits the tab list on a space or a comma too, mirroringexpand. Verified byte for byte against GNUunexpandin the C locale for'2 3',' 2 3','2 3','2, 3'and'1 4 7'; invalid values like-t xstill error as before.